Ability to provide custom cicd and cloud components #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As a devops developer I need to provide custom CI/CD configs with certain adaptions for our infrastructure. As far as I understood, this is currently not possible as only the
dbx
providedcomponents
folder is used.Thus, this PR
components
folder of the cookiecutter git repositoryFor discussion
To be compatible with the upstream
cookiecutter
philosophy I would furthermore suggest toEither
Change the folder structure of the templates. I see the
components
folder a subfolder of the specific template( e.g.dbx/templates/projects/python_basic/render/components
) as all the required variables and code dependencies for these "components" are defined incookiecutter.json
andpost_gen_project.py
. There is no clear separation, thus a change incomponents
does not make any sense if you do not adapt thepython_basic
template.Or
Provide all "components" directly in the cookiecutter
render
template and only remove unused CI/CD files as suggested by the cookiecutter docs. In this case, the various values fornode_type_id
inconf/deployment.yaml
could be rendered with choice variables.This is however not yet implemented here - I can provide the code if desired.
Types of changes
What types of changes does your code introduce to dbx?
Put an
x
in the boxes that applyFurther comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...