Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Jinja2 templates from working dir #845

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

roelschr
Copy link

Proposed changes

Enable users to (optionally) set the Jinja2 base working directory to os.curdir. By using the new option --jinja-working-dir, Jinja will treat the current directory as a working directory and Templates can be loaded from any namespace downstream.

This was the default behavior in version 0.6.0 but was removed at some point. Issue: #844

Types of changes

What types of changes does your code introduce to dbx?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@roelschr roelschr marked this pull request as ready for review September 14, 2023 15:49
Copy link

@RaviShivam RaviShivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants