Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore js flag to format subcommand #1349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andres-lowrie
Copy link
Contributor

Hello

I figured this option may come in handy for users who have different linting/formatting rules for their javascript files but still want to leverage the sqlx formatter. (Which is the case for us)

I took a look at /tests/sqlx/format.spec.ts and the other files in general to see if there was somewhere I could add tests to but didn't find anything obvious. The file that I'm mentioning seems to specifically test the formatting output and not how the cli calls it. If we need to include tests for this addition, please point me in the right direction and I'll do the needful

@lewish lewish changed the base branch from master to main July 20, 2022 15:37
@andres-lowrie
Copy link
Contributor Author

resurrecting this issue, wondering if I'm the only user who would like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant