Assertions configs as protos #1731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have tidied up the diff with the previous PRs, much cleaner now! |
BenBirt
approved these changes
May 10, 2024
Comment on lines
+196
to
+199
| unverifiedConfig.dependencyTargets = unverifiedConfig.dependencies.map( | ||
| (dependency: string | object) => | ||
| typeof dependency === "string" ? { name: dependency } : dependency | ||
| ); |
| @@ -245,6 +188,42 @@ export class Assertion extends ActionBuilder<dataform.Assertion> { | |||
| VerifyProtoErrorBehaviour.SUGGEST_REPORTING_TO_DATAFORM_TEAM | |||
| ); | |||
| } | |||
|
|
|||
| private verifyConfig(unverifiedConfig: any): dataform.ActionConfig.AssertionConfig { | |||
There was a problem hiding this comment.
IMO it'd be cleaner to continue having a real type.
interface LegacyAssertionConfig extends dataform.ActionConfig.AssertionConfig {
dependencies: Resolvable[],
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1732 contains better default assertion schema handling, so should be merged beforehand