Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated actions/github-script #2377

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #2375

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🍄🆙improvement New feature or request 🤫dependencies Pull requests that update a dependency file labels Mar 21, 2024
@mfranzke mfranzke added this to the Open Beta Release milestone Mar 21, 2024
@mfranzke mfranzke self-assigned this Mar 21, 2024
@mfranzke mfranzke linked an issue Mar 21, 2024 that may be closed by this pull request
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2375-chore-updated-actionsgithub-script

@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Mar 21, 2024
@mfranzke mfranzke changed the title refactor: updated github-script refactor: updated actions/github-script Mar 21, 2024
@mfranzke
Copy link
Member Author

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

@mfranzke mfranzke enabled auto-merge March 21, 2024 11:48
@mfranzke mfranzke removed their assignment Mar 21, 2024
@nmerget
Copy link
Member

nmerget commented Mar 22, 2024

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@mfranzke
Copy link
Member Author

mfranzke commented Mar 22, 2024

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

@nmerget
Copy link
Member

nmerget commented Mar 22, 2024

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

@mfranzke
Copy link
Member Author

mfranzke commented Mar 22, 2024

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

@nmerget
Copy link
Member

nmerget commented Mar 22, 2024

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

Because we want to release a beta version? If you have time for it, do it ;)

@mfranzke
Copy link
Member Author

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

Because we want to release a beta version? If you have time for it, do it ;)

I've moved the target for this update to the next release after Beta.

@nmerget nmerget marked this pull request as draft April 11, 2024 06:56
auto-merge was automatically disabled April 11, 2024 06:56

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢📀cicd Changes inside .github folder 🤫dependencies Pull requests that update a dependency file 🍄🆙improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: updated actions/github-script
2 participants