fix: button with invalid variant prop renders now correctly

[bruno-sch]

Proposed changes

Fixes: #2444

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (fix on existing components or architectural decisions)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Further comments

[github-actions]

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-button-invalid-variant-renders-incorrect

[mfranzke]

@bruno-sch based on the screenshots, I would say, that we're not done yet.

[mfranzke]

Suggested change

	&:not([data-variant="filled"]),
	&:not([data-variant="brand"]),
	&:not([data-variant]),
	&[data-variant=""],

This way it might be a little bit more resilient, independent from any future values of data-variant.

[nmerget]

This looks wrong ^.^

[mfranzke]

no way !

[mfranzke]

@bruno-sch I would be perfectly fine to just close the ticket, as we've even also discussed as an option the other day. If someone doesn't follow the pattern and/or (in this case) does only provide the attribute, but no (mandatory) value at all, things might look incorrect and our components don't necessarily need to be totally resilient.