Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with autofocus for drawer #2555

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: issue with autofocus for drawer #2555

wants to merge 1 commit into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 19, 2024

Proposed changes

closes #2035

Could be solved by autoclose? https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog?retiredLocale=de#usage_notes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-autofocus-drawer

@github-actions github-actions bot added the 🏘components Changes inside components folder label Apr 19, 2024
@nmerget nmerget self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke will be requested when the pull request is marked ready for review mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba will be requested when the pull request is marked ready for review dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nmerget nmerget

Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(a11y): Drawer doesn't get attention by screenreader users
1 participant
@nmerget