New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#22963 [CUBRID] Add supplementary features to the CUBRID plugin #23185

Open

longhaseng52 wants to merge 46 commits into dbeaver:devel from longhaseng52:3rd_pr_official

+1,992 −351

Contributor

longhaseng52 commented Mar 20, 2024 •

edited

Display list of indexes
Display list of serials
Display list of synonyms
Display list of triggers
Display list of functions & procedures
Display DDL of view
Create & edit table using UI

longhaseng52 added 11 commits

March 20, 2024 11:13


          Place { at the same line where the method is declared

93e28a5


          Remove file CubridObjectContainer.java

02f8387


          Remove sub table

75b36f3


          Display list of indexes

dc49241


          Display list of serials

5be8ddb


          Display list of synonyms

2d5aa62


          Display list of triggers

c984471


          Display list of functions & procedures

97421bc


          Display DDL of view

7b7b9de


          Create and edit table using UI

10fce07


          Add annotations on methods and parameters

9f824de

LonwoLonwo added external x:cubrid labels

Member

LonwoLonwo commented Mar 20, 2024

Hello @longhaseng52

Thanks for your contribution. We will look at it.
Could you please create a ticket on our issue tracker and add all the next comments in PR, starting with the issue number?
Like #25879 fix code style

Member

LonwoLonwo commented Mar 20, 2024

Oh, yes, I forgot, you already have it: #22963

Then, please always start your commits from issue number: #22963 add indexes support for Cubrid

LonwoLonwo linked an issue

that may be closed by this pull request

[CUBRID] Add supplementary features to the CUBRID plugin #22963

Open

LonwoLonwo reviewed

View reviewed changes

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridCharset.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridCharset.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridCollation.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridCollation.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ns/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridDataSource.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ns/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridDataSource.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedure.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedure.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...ins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedure.java Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...kiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedureParameter.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...kiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedureParameter.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...kiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridProcedureParameter.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...rg.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/meta/CubridMetaModel.java Outdated Show resolved Hide resolved

LonwoLonwo reviewed

View reviewed changes

...rg.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/meta/CubridMetaModel.java Outdated Show resolved Hide resolved

longhaseng52 added 2 commits

March 22, 2024 13:54


          dbeaver#22963 Rename variable in CubridTable.java file

68eaa27


          dbeaver#22963 Add not null condition

2c94499

longhaseng52 force-pushed the 3rd_pr_official branch from 62191af to 2c94499 Compare

March 22, 2024 07:17

longhaseng52 added 4 commits

March 25, 2024 10:20


          dbeaver#22963 Add target object in Synonym

8f82422


          dbeaver#22963 Add parameter kind in CubridProcedureParameter.java

d18c37d


          dbeaver#22963 Fix query error when deleting procedure with UI

2841b8b


          dbeaver#22963 Add scale, precision and ordinal position to table column

d595e78

Member

LonwoLonwo commented Mar 26, 2024

Also, you are now having conflicts in your PR. Please resolve them.

longhaseng52 and others added 4 commits

March 27, 2024 22:27


          dbeaver#22963 Fix formatting view DDL

06d75ef


          dbeaver#22963 Merge branch 'devel' into '3rd_pr_official'

032190b


          Merge branch 'devel' into 3rd_pr_official

d5abcf3


          dbeaver#22963 Add parents of view by calling method getUniqueName()

b3fa7bd

E1izabeth requested a review from LonwoLonwo

March 29, 2024 09:04

E1izabeth approved these changes

View reviewed changes


          dbeaver#22963 Fix Codacy Static Code Analysis suggestion

303be27

Contributor Author

longhaseng52 commented Apr 2, 2024

We exclude Export DB SQL for this moment. It will be implemented in another pull request.

Contributor Author

longhaseng52 commented Apr 20, 2024

Hello, may I know the progress of this PR?
What else do I need to do to get this PR merged?

Member

E1izabeth commented Apr 20, 2024

We passed your PR to our QA team for testing


          Merge branch 'devel' into 3rd_pr_official

b9d03fe

serge-rider requested changes

View reviewed changes

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridUser.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridTable.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridTable.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridTable.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridTable.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridTable.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridUser.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridUser.java Outdated Show resolved Hide resolved

plugins/org.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/CubridUser.java Outdated Show resolved Hide resolved

...rg.jkiss.dbeaver.ext.cubrid/src/org/jkiss/dbeaver/ext/cubrid/model/meta/CubridMetaModel.java Outdated Show resolved Hide resolved

longhaseng52 added 9 commits

May 15, 2024 17:49


          dbeaver#22963 Add constant variable for supportsTrigger function in C…

…ubridUser


          dbeaver#22963 Update supportsTrigger function in CubridTable

c4d1166


          dbeaver#22963 Update constructor in file CubridTable

78d77da


          dbeaver#22963 Remove indexCache in CubridUser

829c72f


          dbeaver#22963 Code style: insert space before open parenthesis

9666b8a


          dbeaver#22963 Change Boolean object to primitive type

a4c2db6


          dbeaver#22963 Remove unused import in CubridMetaModel

695f488


          dbeaver#22963 Add quote object name in SQL

756f988


          dbeaver#22963 Update boolean expression in CubridMetaModel

0156cef

Member

E1izabeth commented May 17, 2024

Thank you for corrections. Your PR is passed to QA team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment