Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected error message when git is not installed #9578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jon-fearer
Copy link

resolves #9537

Problem

The dbt debug command returns an unexpected error message when git is not installed

Solution

Update the test_git method to handle the CommandResultError exception that is thrown when git is not installed.

Output when git is installed:

image

Output when git is not installed (updated behavior):

image

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@jon-fearer jon-fearer requested a review from a team as a code owner February 15, 2024 17:45
Copy link

cla-bot bot commented Feb 15, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @jon-fearer

@jon-fearer
Copy link
Author

Whoops.. forgot to sign the CLA before submitting this. I have now signed it.

@jon-fearer
Copy link
Author

@dbeatty10 @peterallenwebb Let me know if anything else is needed from me here. Thank you

@dbeatty10 dbeatty10 added the community This PR is from a community member label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unexpected error message when git is not installed
2 participants