Feat: populate actual count of failures in run_results.json for passing tests

[tbog357]

resolves #9808

Problem

I build a pipeline using dbt, which has tests run daily. I need to visualize those charts using the results returned in the run_results.json file. But turnout when tests are passed, the number of failures wasn't being populated.

So it would be nice if we could fetch failures even if tests are passed.

Solution

Return failures even if tests are passed.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[jtcohen6]

@tbog357 This sounds reasonable - could I ask you to open an issue explaining the need in slightly more detail? (I get it as, you may have failures even if they don't clear the bar of error_if / warn_if.) We'll just want to do a little bit of thinking to make sure this wouldn't be a behavior change that would surprise someone upon upgrade.

[tbog357]

Hello @jtcohen6, thanks for your reply. I have added a issue #9808 and linked it to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (d1ebf9d) to head (d509f51).
Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9657      +/-   ##
==========================================
- Coverage   88.02%   85.80%   -2.23%     
==========================================
  Files         177      178       +1     
  Lines       22315    22459     +144     
==========================================
- Hits        19643    19270     -373     
- Misses       2672     3189     +517     

Flag	Coverage Δ
integration	83.10% <100.00%> (-2.52%)	⬇️
unit	61.78% <0.00%> (-0.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.