Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad argument passed in tracking _log_result #9754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pol-defont-reaulx
Copy link

resolves #9753

Problem

In tracking.py, the string argument sent to _log_result for http_post is not the right one. It's "GET" and should be "POST"

Solution

Change "GET" to "POST"

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@pol-defont-reaulx pol-defont-reaulx requested a review from a team as a code owner March 12, 2024 15:56
@cla-bot cla-bot bot added the cla:yes label Mar 12, 2024
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (a0abc58) to head (96768c5).
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9754   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         178      178           
  Lines       22451    22451           
=======================================
  Hits        19762    19762           
  Misses       2689     2689           
Flag Coverage Δ
integration 85.48% <100.00%> (ø)
unit 62.21% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10 dbeatty10 added the community This PR is from a community member label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Bad argument sent to logging in tracking function
2 participants