Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CLI Parameter for packages-install-path #9933

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stevenayers
Copy link

@stevenayers stevenayers commented Apr 13, 2024

resolves #9932

Problem

In the docs, under target-path, it says:

Just like other global configs, it is possible to override these values for your environment or invocation by using the CLI option (--target-path) or environment variables (DBT_TARGET_PATH).

However, the cli option for packages-install-path does not exist.

Solution

Add a CLI parameter --packages-install-path which populates DBT_PACKAGES_INSTALL_PATH in the same way --target-path does this for DBT_TARGET_PATH

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@stevenayers stevenayers requested a review from a team as a code owner April 13, 2024 08:50
Copy link

cla-bot bot commented Apr 13, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @stevenayers-bge

@github-actions github-actions bot added the community This PR is from a community member label Apr 13, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (c53d67d) to head (33bd419).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9933      +/-   ##
==========================================
- Coverage   88.13%   85.41%   -2.73%     
==========================================
  Files         178      178              
  Lines       22544    22563      +19     
==========================================
- Hits        19870    19272     -598     
- Misses       2674     3291     +617     
Flag Coverage Δ
integration 85.41% <100.00%> (-0.15%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] CLI Parameter for packages-install-path
1 participant