-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MySqlStreamingChangeEventSource: Convert non-full rows to full rows #5348
base: main
Are you sure you want to change the base?
Conversation
Welcome as a new contributor to Debezium, @shanielh. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
Hi @shanielh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
735e5d6
to
e9e4ac1
Compare
Hi @shanielh the issue reports this as affecting MariaDB but I do not see anything in the code that guards this change specifically to MariaDB. In addition, could this be due to the binlog row format configuration? |
Hi @Naros, thanks for the fast response. I think this might happen in MySQL too since it's related to the MySQL binlog wire format, it might be related to the configuration but I couldn't find anything related to it. I'll try look for more information tomorrow. |
Hi @shanielh can you please add some tests for this change? |
Hi @Naros, sure. I'll try to add tests using minimal row binlog setting. I hope to do that by Monday. |
Hi @shanielh, just wanting to follow-up and see if you have any questions or issues adding the test. |
Yeah actually I do, should I change the format of the row to minimal, or should I somehow create another instance of a MySQL in which I'll change the configuration? |
@shanielh I don't think it is necessary to create another long-running instance
|
This should fix DBZ-7591