Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google cloud vision OCRDetector #328

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paul-tharun
Copy link

Added google cloud vision as OCR engine.
Implementation is similar to how the AWS TextractOCREngine is implemented

@JaMe76
Copy link
Contributor

JaMe76 commented May 3, 2024

Thanks for your PR, super happy to merge, once I get time reviewing this next week!

1.) Could you maybe add a small test? Something very similar to this would be very helpful. The API itself is mocked, it should be very straight forward.

2.) Could you add the google.cloud.vision dependency to the setup.py: additional_deps and _DEPS ? This will add yet another dependency, but I will have to refactor this anyway.

Thanks again.

Copy link
Contributor

@JaMe76 JaMe76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your PR.

The code itself looks fine.

1.) Could you maybe add a small test? Something very similar to this would be very helpful. The API itself is mocked, it should be very straight forward.

2.) Could you add the google.cloud.vision dependency to the setup.py: additional_deps and _DEPS ? This will add yet another dependency, but I will have to refactor this anyway.

3.) Please check the remaining lint, mypy and test -issues:

https://github.com/deepdoctection/deepdoctection/actions/runs/8951911962/job/24629033613?pr=328
https://github.com/deepdoctection/deepdoctection/actions/runs/8951911962/job/24629034050?pr=328
https://github.com/deepdoctection/deepdoctection/actions/runs/8951911963/job/24629034108?pr=328
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants