Make gif output conditionally based on the interpolated frames.

[gravitate-dev]

This is to fix a bug where make_gif is checked and RIFE/FILM is applied. The output gif should be based off of the RIFE/FILM output.

Without this change, the make_gif will generate a gif from the non interpolated frames which defeats the purpose of RIFE/FILM if a user wants a gif output with highquality with gifski.

[gravitate-dev]

Ready for approval

[andyxr]

So, if interpolation is on, the GIF will be interpolated. Is there no opportunity for the user to see the non-interpolated GIF? E.g when we interpolate a render, we provide both the normal video and the interpolated one.

[gravitate-dev]

Well if interpolation is on, I frankly do not see the value in adding both the non interpolated gif. and interpolated gif.

Reasoning:
I did this because why have a 10fps gif when u can have the 20 or 30fps gif? I do not see the point of generating two gifs especially if the user explicitly setup the interpolation options, they definitely would want the interpolated one

[andyxr]

Well if interpolation is on, I frankly do not see the value in adding both the non interpolated gif. and interpolated gif.

Reasoning: I did this because why have a 10fps gif when u can have the 20 or 30fps gif? I do not see the point of generating two gifs especially if the user explicitly setup the interpolation options, they definitely would want the interpolated one

My reasoning is that the user is then given the choice of keeping their original art, or using the interpolated version. We keep both the original render video and the interpolated one; why should a GIF be different? Just wanna make sure that we're not taking away a feature and replacing it with something else. Does that make sense? Else the user will have to do two renders if they wanna keep the original to compare it with the interpolated version.

[reallybigname]

It also doesn't show the RIFE version in "Click here after generation..." area, and there are issues with upscaling and audio or something as I recall. Basically, those are all post-processes to the actual process, which includes GIF output. I suggest that rather than convolute those processes more, we just make a "video to GIF" or "frames to GIF" option. Probably better to just add a GIF option to the already existing "Frames to Video".

As I recall, GIFs are limited to 30fps in the code. And, most people are using RIFE to go above that. So, that would also have to be addressed with errors, or just automatically slowed down to 30fps.