[Spark] Add more tests checking the preservedRowTracking tag #2953
+196
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
force-pushed
the
stack/move-preserve-tag-to-commit
branch
from
c3d1656
to
44c6dc3
Compare
longvu-db
changed the title
longvu-db
changed the title
longvu-db
changed the title
longvu-db
changed the title
longvu-db
force-pushed
the
stack/move-preserve-tag-to-commit
branch
from
44c6dc3
to
66230a9
Compare
longvu-db
force-pushed
the
stack/move-preserve-tag-to-commit
branch
from
66230a9
to
83b4719
Compare
longvu-db
force-pushed
the
stack/move-preserve-tag-to-commit
branch
from
f697735
to
1bf0b0f
Compare
johanl-db
reviewed
Apr 24, 2024
Comment on lines
1111
to
1113
| val allTags = RowTracking.addPreservedRowTrackingTagIfNotSet( | ||
| protocol, metadata, tags) | ||
|
|
There was a problem hiding this comment.
Blindly tagging all commits as preserving row tracking is pretty brittle: there may be a case (now or introduced in the future) that doesn't preserve row tracking and there's virtually no chance that we detect it and correctly mark row tracking information as not preserved.
We could instead add tags to the most relevant code paths to explicitly mark that row tracking is preserved, at least in inserts (WriteIntoDelta, InsertOnlyMergeExecutor) so that most data ingestion operations are covered
We should in any case have a test somewhere that checks that the preserved row tracking tag is set to true for inserts.
There was a problem hiding this comment.
Okay, let's think more about it, but for now let's keep the Preserving tests in the commands that we preserved Row Tracking (that I forgot to add in the previous Delta PRs).
...est/scala/org/apache/spark/sql/delta/columnmapping/RemoveColumnMappingRowTrackingSuite.scala
Outdated
Show resolved
Hide resolved
...est/scala/org/apache/spark/sql/delta/columnmapping/RemoveColumnMappingRowTrackingSuite.scala
Outdated
Show resolved
Hide resolved
longvu-db
force-pushed
the
stack/move-preserve-tag-to-commit
branch
from
1bf0b0f
to
a6eac93
Compare
longvu-db
changed the title
longvu-db
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add more tests checking the behavior of the
preservedRowTrackingtag in specific commands like Merge/Update/Delete/Optimize/Remove Column Mapping, we introduced Preserving Row Tracking for these commands in previous PRs, which include adding thepreservedRowTrackingtag.How was this patch tested?
Added UTs.
Does this PR introduce any user-facing changes?
No.