[Spark] ALTER TABLE ALTER COLUMN SYNC IDENTITY SQL support #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
scottsand-db
reviewed
May 1, 2024
| @@ -2461,6 +2461,11 @@ trait DeltaErrorsBase | |||
| ) | |||
| } | |||
|
|
|||
| def identityColumnAlterNonIdentityColumnError(): Throwable = { | |||
| new AnalysisException( | |||
| "ALTER TABLE ALTER COLUMN SYNC IDENTITY cannot be called on non IDENTITY columns") | |||
There was a problem hiding this comment.
You cannot use new AnalysisException. This doesn't compile against Spark Master.
Please use new DeltaAnalysisException and use a proper error class
olaky
reviewed
May 2, 2024
| withSimpleGeneratedByDefaultTable(start, step) { | ||
| // Test empty table. | ||
| val oldSchema = DeltaLog.forTable(spark, TableIdentifier(tblName)).snapshot.schema | ||
| sql(s"ALTER TABLE $tblName ALTER COLUMN id SYNC IDENTITY") |
There was a problem hiding this comment.
Can you test the other variants of the SQL syntax? Right now you only test ALTER TABLE ALTER COLUMN SYNC IDENTITY, but we should validate the SQL syntax for ALTER TABLE CHANGE COLUMN SYNC IDENTITY, etc.
| test("alter table sync identity overflow") { | ||
| withSimpleGeneratedByDefaultTable(startsWith = 1L, incrementBy = 10L) { | ||
| sql(s"INSERT INTO $tblName VALUES (${Long.MaxValue}, 'a')") | ||
| intercept[ArithmeticException](sql(s"ALTER TABLE $tblName ALTER COLUMN id SYNC IDENTITY")) |
There was a problem hiding this comment.
Can you add a test that we can't call SYNC IDENTITY for non-Delta sources?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is part of #1959
In this PR, we add SQL support for
ALTER TABLE ALTER COLUMN SYNC IDENTITY.This is used for GENERATED BY DEFAULT Identity Columns, where a user may want to manually update the identity column high watermark.
How was this patch tested?
This PR adds a new test suite
IdentityColumnSyncSuite.Does this PR introduce any user-facing changes?
Yes. We introduce the SQL syntax
ALTER TABLE (ALTER| CHANGE) COLUMN? <colName> SYNC IDENTITYinto Delta. This will update the high watermark stored in the metadata for that specific identity column.Example Usage