feat: custom resource links #2562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejoeejoee
force-pushed
the
feat-custom-resource-links
branch
7 times, most recently
from
30dd834
to
a50f25c
Compare
thejoeejoee
force-pushed
the
feat-custom-resource-links
branch
from
a50f25c
to
1c96f9d
Compare
thejoeejoee
force-pushed
the
feat-custom-resource-links
branch
4 times, most recently
from
2eae60e
to
97b83e5
Compare
thejoeejoee
force-pushed
the
feat-custom-resource-links
branch
from
97b83e5
to
0ed934d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As described in #2561, I'm proposing a solution for custom resource links.
I've got some questions during implementation:
internal.KeyFieldsfrom context is not taken into account in allListerimplementations -- that's intentional? I've added support toTable, makes sense to have implemented in allListerimplementations?customResourceLinksas it's not only for custom resources, but also for built-in resources, and it's not only for relations, but also for filtering. I'm open to suggestions.