Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snap completion #2633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add snap completion #2633

wants to merge 1 commit into from

Conversation

jrib
Copy link

@jrib jrib commented Mar 19, 2024

  • Update base to core22
  • Add completion
  • Update instructions to use --classic

@jrib jrib mentioned this pull request Mar 19, 2024
@jrib
Copy link
Author

jrib commented Mar 19, 2024

@derailed replying to your comment in the other PR:

It's hard for me to tell from the original pr how this will fix the snap install?

The main change is to have users use --classic when installing. This removes the need to figure out snap's sandboxing. It's what the helm and kubectl snap are doing too so I don't see much harm.

I did try to get the sandboxing to work but eventually decided to go see how helm and kubectl were doing it since they would need the same permissions. That's when I remembered they just use --classic to avoid having to deal with the sandboxing.

metanovii and I both also ended up updating the base to core22 which changes the syntax slightly.

I haven't published to the snap store but if there's any issue publishing this new version of the snap, I'm happy to work on it.

@derailed
Copy link
Owner

@jrib Very kind. Thank you Jason!
I've just merged Sergey's updates so we need to resolve conflicts.
FYI I had initially tried to use --classic mode but could not get snapscraft's folks approval to run outside the sandbox ;(
Hence not sure if these updates will resolve this?

@metanovii
Copy link
Contributor

@jrib Very kind. Thank you Jason! I've just merged Sergey's updates so we need to resolve conflicts. FYI I had initially tried to use --classic mode but could not get snapscraft's folks approval to run outside the sandbox ;( Hence not sure if these updates will resolve this?

I doubt these changes will solve the problem you're talking about. As far as I remember, they need an explanation for what classic is needed. One way or another, snapstore has a lot of applications with classic, so I think this problem can be solved with snapstore support.

@derailed
Copy link
Owner

@metanovii right! A while back, I've spent a lot of time trying to get the snap folks to grant classic mode for k9s.
Did not get anywhere fast, so would be great if someone here want to take that on.

@jrib jrib changed the title Fix snap build Add snap completion Mar 19, 2024
@jrib
Copy link
Author

jrib commented Mar 19, 2024

I went ahead and changed this PR to just have the added completion for the snap.

Did not get anywhere fast, so would be great if someone here want to take that on.

I found the old threads trying to get the snap for k9s to have the right permissions.

The threads are 1 and 2.

I am learning a lot about snap :). I'll read through the threads later today and see if there's some way for me to help make progress with the snap store.

@jrib
Copy link
Author

jrib commented Mar 20, 2024

I opened a new topic in the snapcraft forum to see if we can get a new conversation started.

@derailed
Copy link
Owner

@jrib Very kind and well crafted! Thank you Jason for your help with this!!

@jrib
Copy link
Author

jrib commented Apr 4, 2024

@derailed looks like they are willing to grant classic confinement to the k9s snap. I think they'll need some action on your part now to vet you as the publisher of k9s. Pinging you here in case you don't receive notifications from forum.snapcraft.io. If there is anything I can do to help, let me know.

@derailed
Copy link
Owner

derailed commented Apr 4, 2024

@jrib Excellent! Thank you Jason for seeing this thru!!

@scibaric
Copy link

@derailed sahnaseredini pinged you about providing needed data. seems like they are still waiting for your response. If this is not the case ignore my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants