-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Kotlin 2.0.0 #6640
Update to Kotlin 2.0.0 #6640
Conversation
Hey @3flex after trying the commit 429a178 as you mentioned here #6715 (comment). I've been able to compile your branch and generate the library on my MavenLocal. But when I've run
Thanks :) |
You probably need to follow steps here: https://docs.gradle.org/8.3/release-notes.html#kotlin_k2 and be sure to use Gradle 8.3 or higher. Also have a read of https://kotlinlang.org/docs/whatsnew-eap.html#current-k2-compiler-limitations |
8652daa
to
68f3cc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6640 +/- ##
============================================
- Coverage 84.68% 84.36% -0.33%
- Complexity 4001 4176 +175
============================================
Files 574 574
Lines 12011 11913 -98
Branches 2476 2458 -18
============================================
- Hits 10172 10050 -122
- Misses 598 613 +15
- Partials 1241 1250 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
If this is cherry picked into the 1.x branch, these PRs will also need to be picked: |
Kotlin 2.0 has just been released. I see this has been merged - are you planning to publish a release relatively soon? :) |
I haven't made releases previously so I can't say, but you can try snapshots until a new one is pushed out. |
@cortinico are you planning a patch with Kotlin 2.0.0 support? (current 1.23.6 works, but I would assume that the K2 improvements propagate to compiler-embedded, so a detekt patch/minor release could benefit from a 2x speed improvement?) |
I was thinking we can cut a |
It feels like that might be a long way away (from stable), there are still breaking changes coming in refractors, right? So alpha would require some to migrate again and again, and therefore I personally wouldn't actually use the alpha in a live project (e.g. at work) and miss out on speed of a stable compiler. I think @3flex can comment on the complexity of cherry, based on the above comment it's 3 small PRs, however with one of them forcing language version, does it mean we wouldn't benefit from K2's improvements? |
Language version 1.9 limitation applies to compiler plugin only. The CLI and Gradle in theory get speedups but I haven't tested anything. Cherry picking sounds like a good plan. |
Fixes #6715
This is safe to release with alpha/beta dependencies in my opinion. poko 0.16.0-beta01 is based on Kotlin 2.0.0-RC3 which is the same as 2.0.0. kctfork is only used in tests.