Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new id for the rules #7313

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add new id for the rules #7313

wants to merge 3 commits into from

Conversation

BraisGabin
Copy link
Member

This PR changes some names. The first one is that Rule has a Name instead of an Id. A rule can no longer be identified by a static name.

The second one is to introduce a new id that can be different from Rule.Name.

And because now RuleInfo had a name and an id I renamed it to RuleInstance.

Naming is REALLY difficult so any help here is more than welcome.

This PR is part of #7263 but because that PR contains a lot of decissions I prefer to split it so we can talk about each one in different PRs but I recomment to read #7263 so you get the full context about why this change is needed.

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.78%. Comparing base (bd39205) to head (c2f1dfa).

Files Patch % Lines
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 89.47% 0 Missing and 2 partials ⚠️
...arturbosch/detekt/core/suppressors/Suppressions.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7313   +/-   ##
=========================================
  Coverage     84.78%   84.78%           
  Complexity     3993     3993           
=========================================
  Files           576      576           
  Lines         12021    12024    +3     
  Branches       2478     2478           
=========================================
+ Hits          10192    10195    +3     
  Misses          598      598           
  Partials       1231     1231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants