-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new id for the rules #7313
Open
BraisGabin
wants to merge
3
commits into
main
Choose a base branch
from
new-id-on-ruleinstance
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new id for the rules #7313
+249
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detekt-ci
added
rules
api
core
cli
gradle-plugin
formatting
reports
suppressors
compiler-plugin
labels
May 19, 2024
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 14:08
4bb7aff
to
4b73dd7
Compare
BraisGabin
added
breaking change
Marker for breaking changes which should be highlighted in the changelog
and removed
rules
cli
gradle-plugin
formatting
reports
suppressors
compiler-plugin
labels
May 19, 2024
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 14:17
4b73dd7
to
2fb58ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7313 +/- ##
=========================================
Coverage 84.78% 84.78%
Complexity 3993 3993
=========================================
Files 576 576
Lines 12021 12024 +3
Branches 2478 2478
=========================================
+ Hits 10192 10195 +3
Misses 598 598
Partials 1231 1231 ☔ View full report in Codecov by Sentry. |
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 14:36
2fb58ac
to
cd28075
Compare
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
2 times, most recently
from
May 19, 2024 14:48
0015d49
to
10aed8b
Compare
detekt-api/src/testFixtures/kotlin/io/gitlab/arturbosch/detekt/test/TestFactory.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/testFixtures/kotlin/io/gitlab/arturbosch/detekt/test/TestFactory.kt
Fixed
Show fixed
Hide fixed
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 15:00
10aed8b
to
cd33a1f
Compare
detekt-api/src/testFixtures/kotlin/io/gitlab/arturbosch/detekt/test/TestFactory.kt
Fixed
Show fixed
Hide fixed
detekt-api/src/testFixtures/kotlin/io/gitlab/arturbosch/detekt/test/TestFactory.kt
Fixed
Show fixed
Hide fixed
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 15:02
cd33a1f
to
d638fad
Compare
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 19, 2024 15:14
d638fad
to
0eeaaaf
Compare
BraisGabin
force-pushed
the
new-id-on-ruleinstance
branch
from
May 20, 2024 20:59
0eeaaaf
to
c2f1dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
breaking change
Marker for breaking changes which should be highlighted in the changelog
cli
compiler-plugin
core
formatting
gradle-plugin
reports
rules
suppressors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes some names. The first one is that
Rule
has aName
instead of anId
. A rule can no longer be identified by a static name.The second one is to introduce a new
id
that can be different fromRule.Name
.And because now
RuleInfo
had aname
and anid
I renamed it toRuleInstance
.Naming is REALLY difficult so any help here is more than welcome.
This PR is part of #7263 but because that PR contains a lot of decissions I prefer to split it so we can talk about each one in different PRs but I recomment to read #7263 so you get the full context about why this change is needed.