Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new May 2024 devices. #412

Merged
merged 8 commits into from May 22, 2024
Merged

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented May 7, 2024

Add support for the new May 2024 devices:

  • iPad Air (11-inch)
  • iPad Air (13-inch)
  • iPad Pro (11-inch)
  • iPad Pro (13-inch)

Fixes #413

@Zandor300 Zandor300 marked this pull request as ready for review May 21, 2024 19:49
.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Collection literals should not have trailing commas.
trailing_comma Tests.swift:487

.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Collection literals should not have trailing commas.
trailing_comma Tests.swift:550

.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Collection literals should not have trailing commas.
trailing_comma Tests.swift:634

.iPadPro12Inch6
.iPadPro12Inch6,
.iPadPro11M4,
.iPadPro13M4,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Collection literals should not have trailing commas.
trailing_comma Tests.swift:662

Copy link

github-actions bot commented May 21, 2024

8 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L652 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:652
⚠️ Source/Device.generated.swift#L1193 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1193
⚠️ Source/Device.generated.swift#L1439 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1439
⚠️ Source/Device.generated.swift#L1599 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1599
⚠️ Source/Device.generated.swift#L1739 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1739
⚠️ Source/Device.generated.swift#L2399 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2399
⚠️ Source/Device.generated.swift#L2455 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2455

SwiftLint found issues

Warnings

File Line Reason
Tests.swift 487 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 550 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 634 Collection literals should not have trailing commas. (trailing_comma)
Tests.swift 662 Collection literals should not have trailing commas. (trailing_comma)
Device.generated.swift 652 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1193 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1439 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1599 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1739 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2399 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2455 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

@Zandor300 Zandor300 merged commit 1d30c24 into master May 22, 2024
16 checks passed
@Zandor300 Zandor300 deleted the feature/2024-may-devices branch May 22, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for 13 inch iPad devices
1 participant