fix:resolved PR review comments also remove check for virtual cluster #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laeeqdev
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
|
kripanshdevtron
approved these changes
May 10, 2024
Laeeqdev
changed the title
Laeeqdev
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Laeeqdev
changed the title
Kishan789dev
pushed a commit
that referenced
this pull request
May 13, 2024
Kishan789dev
added a commit
that referenced
this pull request
May 29, 2024
* issue has been on code level * added the changes * changes made to fix the bug is done * Delete go.sum * Delete go.mod * fix: grpc error handling for TemplateChart req (#4980) * grpc error handling * fix * fix: terminate sync if in progress (#4946) * terminate operation before sync * using method for checking manual sync * terminating only in case of error * handling termination error * updating sync function * fix: Kubelink Requests getting Failed for gRPC method GetAppDetails (#5012) * fixed * code review comments * fix: deleted api token can be reused if created again with same name (#4978) * introuddced api token versioning * fix * reverted wire_gen * migration udpated and minor refactor * refactor * moved const from apiToken pkg to user * reverted wire_gen * refactor * reverted wire_gen * concurrency case handled * fix * commented wherever necessary * refactor * fix * refactor * refactor * wip * refactor * added comments and minor refactor * refactor * refactoring * fix * added comments around cyclic import * added few more comments * sql script no updated * feat: Introduction to feasibility in Deployment (#4862) * introduction to feasibility * moved feasibility in trigger/devtronApps * feasibility refactorings * refactoring and feasibility manager * removing vulnerability changes * vulnerability checks retract * dry run removed * dry run checks removed * refactoring * removing unnecessary code * comments * trigger request * doc: Changes made in the doc according to the newer version (#5024) * Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes * added failed workflow in ISLastReleaseStopType method (#5005) * fix: Dockerfile ubuntu version (#5022) * Update DockerfileEA * Update Dockerfile * doc: Added new doc in the index (#5029) * Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes * added the new doc in the index file * fix: handle for wrong format of k8s version in semvercompare func in cronjob template charts (#5016) * handle for wrong format of k8s version in semvercompare func in cronjob template charts * TestStripPrereleaseFromK8sVersion UT's added * constants added * incorporated code review changes * merge main * feat: CD Trigger Plugin (#4810) * Add files via upload CD plugin * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 231_devtron_CD_trigger_v1.0.0.down.sql to 238_devtron_CD_trigger_v1.0.0.down.sql * Rename 231_devtron_CD_trigger_v1.0.0.up.sql to 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 238_devtron_CD_trigger_v1.0.0.down.sql to 240_devtron_CD_trigger_v1.0.0.down.sql * Rename 238_devtron_CD_trigger_v1.0.0.up.sql to 240_devtron_CD_trigger_v1.0.0.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * fix: terminal stuck in connecting state (#4989) * closing channel after write operation * removing close * using buffered channel * wip: making done channel bufferred * terminal racecondition and deadlock fix * wire run * removing done send call * updating bound channel send function * panic handled (#5036) * fix: git material saved in transaction (#5040) * git material flow added in transaction * wire refactored * code review comments incorporated * code review comments incorporated * code review comments incorporated * fix: App create api validations (#5019) * wip * error handling done * fix --------- Co-authored-by: ayushmaheshwari <ayush@devtron.ai> * gitops update updated (#5055) * feat: Plugin to trigger Devtron Job (#5053) * feat: Plugin to trigger Devtron Job (#5052) * Update 241_devtronJobTrigger.up.sql * fix: handle 5xx in fetch resource tree api and cd-trigger (#5050) * handle context cancelled and deadline exceeded in fetch resource tree api * handle context cancelled and deadline exceeded error for resource tree fetch api for acd deployment * handle context cancelled and deadline exceeded error sync argo app with normal refresh * revert TIMEOUT_IN_SECONDS * revert bean TimeoutSlow param * fix * feat: resource scan (#4977) * cherry-pick * incorporating feedbacks * sync with main * misc: uniform GitHub action (#5069) * Update azure-devops-issue-sync.yml * Update chart-sync.yaml * Update create-release.yml * Update enterprise-repo-sync.yaml * Update pager-duty-issue-escalate.yaml * Update update-release-notes.yml * Update chart-sync.yaml * Update create-release.yml * Update enterprise-repo-sync.yaml * Update update-release-notes.yml * Update enterprise-repo-sync.yaml --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * fix (#5074) * gitops validation in api (#5082) * condition fix (#5088) * handled namespace case if deleted by kubectl (#5081) Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> * resolved PR review comments also remove check for virtual cluster (#5095) * feat: added sql for release and release channels (#4898) * added sql for relese feat * updated sql script no * renamed sql files * updated schema for release & release track * fixes in schema * updated schema * made changes in old schemas * enum correction * minor change in script * sql script update * updated script * updated sql script no * exposed release resource * updated sql script no * updated release catalog data * added rescind status change policy handling * renaming policy json field * updated schema ordering * updated global policy version * updated policy json * prod bug fix * updated policy lock status * added action check policy release * wip * updated policy for release status * updated down sql * updated sql script no. * fixed autocorrect issues * added first released on key for release * updated task run migration * Added task run down migration * sql script change * updated policy for action check - instruction patch * fixed schema merge conflict --------- Co-authored-by: Shivam-nagar23 <shivam@devtron.ai> * sync with main * final fixes done * final code ready fo the pr * changes suggested are incorporated * missed changes in a file from above commit are added and committing now * changes done for adding a if condition for apps --------- Co-authored-by: ashishdevtron <141303172+ashishdevtron@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: satya_prakash <155617493+SATYAsasini@users.noreply.github.com> Co-authored-by: jatin-jangir-0220 <122791251+jatin-jangir-0220@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: shaileshmehta16 <159411935+shaileshmehta16@users.noreply.github.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> Co-authored-by: ayushmaheshwari <ayush@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com> Co-authored-by: Laeeq Ahmad <155711991+Laeeqdev@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Shivam-nagar23 <shivam@devtron.ai> Co-authored-by: ShashwatDadhich <dadhichshashwat1808@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4959
Checklist:
Does this PR introduce a user-facing change?