Chewxy/update btree insertion #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewxy
requested review from
jarifibrahim,
manishrjain and
martinmr
as code owners
chewxy
commented
Nov 18, 2020
| @@ -377,7 +404,7 @@ func (t *Tree) split(pid uint64) node { | |||
| nn := t.newNode(n.bits()) | |||
| // Re-read n as the underlying buffer for tree might have changed during newNode. | |||
| n = t.node(pid) | |||
| rightHalf := n[keyOffset(maxKeys/2):keyOffset(maxKeys)] | |||
| rightHalf := n[keyOffset(maxKeys/2):keyOffset(maxKeys-1)] | |||
There was a problem hiding this comment.
this is where I start getting uncomfortable with this PR. I will have to better study this btree impl.
There was a problem hiding this comment.
I can help with the logic of this custom implementation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is