-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve portrait positions and position event #2123
Draft
Jowan-Spooner
wants to merge
16
commits into
dialogic-godot:main
Choose a base branch
from
Jowan-Spooner:portrait-position-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve portrait positions and position event #2123
Jowan-Spooner
wants to merge
16
commits into
dialogic-godot:main
from
Jowan-Spooner:portrait-position-updates
+1,124
−750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Jowan-Spooner
commented
Mar 3, 2024
- Make portrait positions be referenced by name (string).
- PortraitContainers can have a list of "names"
- improve VN portrait layer (better spacing)
- improve Shortcode Event save/load code.
- can now Save, whether a shortcode had been set.
- allow shortcode values to contain = but not unescaped "
- Implement multitween (allowing multiple tweens to contribute to the same property)
- Implement container movement, rotation and resizing
- Add "position-suggestions" field in Portrait settings
- Improve position event
- adds translation, rotation, resize
- adds tweening settings (ease/trans/await)
- Add a debug draw mode for PortraitContainers
Positions can now have a list of identifiers.
- improve VN portrait layer (better spacing) - improve Shortcode Event save/load code. - can now Save, whether a shortcode had been set. - allow shortcode values to contain = but not unescaped " - Implement multitween (allowing multiple tweens to contribute to the same property) - Implement container movement, rotation and resizing - Add "position-suggestions" field in Portrait settings - Improve position event - adds translation, rotation, resize - adds tweening settings (ease/trans/await) - Add a debug draw mode for PortraitContainers
Jowan-Spooner
added
Enhance ⚡
Improve a feature's workflow.
Feature✨
Needs testing
We don't understand this problem fully yet
labels
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhance ⚡
Improve a feature's workflow.
Feature✨
Needs testing
We don't understand this problem fully yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.