Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subsystem history. #2233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AnidemDex
Copy link
Contributor

Hello everyone, did you miss me?

Update variable type for _result instead of letting the engine guessing the type.

For some reason in 4.3 (godotengine/godot#92021 probably) can't guess the type of that very specific line, maybe because can't even parse the referenced class so it just throw it as variant and let it work until fails?

This kinda works (as is just a solution in place that solved Emi traceback). Tested with https://github.com/dialogic-godot/test-project exporting to linux, using Godot v4.3.dev6.official [64520fe67].

It may fix #2231 ? I'm not sure, that traceback seems more related to Editor* classes being referenced in exported game

Update variable type for _result instead of letting the engine guessing the type.
@Jowan-Spooner
Copy link
Collaborator

Tbh I would prefer just removing the _result capturing. I think Cake added this, because they enabled very rigorous godot warnings, but I truly feel that at that point it's messing with the readability of the code if we were to actually capture the "result" everytime we connect a signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported windows projects crash immediately after startup
2 participants