Feat react style #1457
Merged
Feat react style #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiyuki
approved these changes
Apr 29, 2024
hiyuki
reviewed
May 14, 2024
| // RN 不支持的颜色格式 | ||
| const colorRegExp = /^\s*(lab|lch|oklab|oklch|color-mix|color|hwb|lch|light-dark).*$/ | ||
|
|
||
| function verifyValues ({ prop, value, valueType }) { |
There was a problem hiding this comment.
统一为const xx = ()=>{}的方式定义吧
hiyuki
reviewed
May 20, 2024
| const unsupportedValueError = ({ prop, value }) => { | ||
| if (isIllegalValue({ prop, value })) { | ||
| const content = `Property [${prop}] only support value [${SUPPORTED_PROP_VAL_ARR[prop]?.join(',')}] in React Native environment, the value [${value}] does not support!` | ||
| error(content) |
hiyuki
reviewed
May 20, 2024
| needStringify = false | ||
| if (cssPrefixExp.test(prop) || cssPrefixExp.test(value)) return | ||
| let newData = rulesRunner({ prop, value }) | ||
| if (!newData.length) { |
There was a problem hiding this comment.
同时判断newData为false时直接return移除该属性
hiyuki
reviewed
May 20, 2024
| newData.forEach(item => { | ||
| prop = dash2hump(item.prop) | ||
| value = item.value | ||
| if (!value) return |
There was a problem hiding this comment.
逻辑不严谨，建议使用显式返回false移除，当前逻辑会把width:0这样的合法属性误删
hiyuki
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.