New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add TypeScript as a dependency #2588
base: master
Are you sure you want to change the base?
Conversation
|
Needs small rebase (sorry 😄 ) . @wojtekmaj I'm open to this, but not sure I see the usage if we aren't migrating to TS. Can you expand on how DX get's improved? |
This PR does NOT migrate the codebase to TypeScript nor indicates intent to do so in the future. What it does is simply installs TypeScript, so that developer experience (when writing JavaScript!) can be improved.
On top of that, this makes
yarn tsc
command available. At the moment, it still produces a lot of errors, so it's pretty useless, but as #2587 (and the PRs that come after that) gets merged, slowly but surely we'll have increased type safety.Eventually, we could consider having type checking as a CI step to ensure better quality. Still, writing JavaScript!