add modifiers to message_builder so plugins can customize subject/body/html #26867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megothss
reviewed
May 6, 2024
lib/email/message_builder.rb
Outdated
| @@ -126,6 +126,7 @@ def subject | |||
| else | |||
| subject = @opts[:subject] | |||
| end | |||
| subject = DiscoursePluginRegistry.apply_modifier(:user_notification_subject, subject,@opts) | |||
There was a problem hiding this comment.
Message builder is also used for other e-mails type, not only notifications.
The modifiers name should be more generic, something like message_builder_subject for example.
lib/email/message_builder.rb
Outdated
| @@ -164,6 +165,7 @@ def html_part | |||
| html_body: html_override.html_safe, | |||
| }, | |||
| ) | |||
| html = DiscoursePluginRegistry.apply_modifier(:user_notification_html_part, html,@opts) | |||
There was a problem hiding this comment.
Like above, maybe message_builder_html_part?
lib/email/message_builder.rb
Outdated
| @@ -184,6 +186,7 @@ def body | |||
| body << "\n" | |||
| body << @template_args[:unsubscribe_instructions] | |||
| end | |||
| body = DiscoursePluginRegistry.apply_modifier(:user_notification_body, body,@opts) | |||
There was a problem hiding this comment.
Like above, maybe message_builder_body?
markvanlan
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also add notification_type to email_opts so plugins can access it)