DEV: move post flags into database #26951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
i18n
lis2
force-pushed
the
custom-flags
branch
3 times, most recently
from
286d8ad
to
b0161a0
Compare
lis2
commented
May 14, 2024
There was a problem hiding this comment.
Okay there is a lot here, but we are building the foundation :) Sorry if some of this is a bit unclear, it's been a long day, please let me know if you need clarification on anything. The main thing I am concerned about is the various different "things" each flag can be used against (post, topic, chat message) and how the existing legacy post action type and reviewable score records tie into all of this.
|
OK re-evaluating based on your internal comments and guidance on the _type columns Kris, I think the main change we need to make here is to:
Then also just the few other suggestions here that are more minor then it can be good to go. |
|
@martin-brennan thank you for the review. Everything should be fixed 🤞 |
martin-brennan
approved these changes
May 20, 2024
This is preparation for a feature that will allow admins to define their custom flags. Current behaviour should stay untouched.
lis2
added a commit
that referenced
this pull request
May 21, 2024
CvX
pushed a commit
that referenced
this pull request
May 21, 2024
This is preparation for a feature that will allow admins to define their custom flags. Current behaviour should stay untouched.
CvX
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for a feature that will allow admins to define their custom flags. Current behaviour should stay untouched.
A basic guardian was also defined. In addition, default translations are handled. Old flags will use translations, but at this point, admin defined flags will not be translated.