UX: Group membership PMs thread #26974
Conversation
|
|
github-actions
bot
added
the
i18n
| @@ -638,7 +638,6 @@ en: | |||
| request_membership_pm: | |||
| title: "Membership Request for @%{group_name}" | |||
| request_accepted_pm: | |||
| title: "You've been accepted into @%{group_name}" | |||
There was a problem hiding this comment.
Since this is no longer a Topic, the title field here is not needed. Slashed this one for the PR, but leaving the others for now in case we don't want to take these out.
There was a problem hiding this comment.
@pmusaraj Should I remove this line from the other ymls?
There was a problem hiding this comment.
@pmusaraj Should I remove this line from the other ymls?
No, removing it from the English locale file is enough. The other locale files are updated automatically.
There was a problem hiding this comment.
Awesome, thank you!
brrusselburg
force-pushed
the
br/group_messages
branch
from
319eb01
to
a4df064
Compare
brrusselburg
force-pushed
the
br/group_messages
branch
2 times, most recently
from
33f4820
to
320ccf3
Compare
There was a problem hiding this comment.
This is ready to merge @brrusselburg, thank you, just left a few minor comments.
brrusselburg
force-pushed
the
br/group_messages
branch
from
6fc7667
to
b9dc9cc
Compare
|
Seeing the failures; I'll fix them after I finish eating 🫡 |
brrusselburg
force-pushed
the
br/group_messages
branch
from
b9dc9cc
to
95a59fc
Compare
brrusselburg
force-pushed
the
br/group_messages
branch
from
95a59fc
to
ed6c20e
Compare
|
Thanks @brrusselburg, this is looking great, time to merge! Nice work! |
Slight alteration on group request messaging per this meta post.
Instead of creating two separate Topics when a user (1) requests to join a group and (2) gets accepted in, this makes the acceptance message into a Post under the origin group request Topic.