DEV: Full system specs coverage for signup/login #26977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmusaraj
reviewed
May 13, 2024
pmusaraj
approved these changes
May 14, 2024
| expect(signup_modal).to be_open | ||
| expect(signup_modal).to have_no_password_input | ||
| expect(signup_modal).to have_valid_username | ||
| expect(signup_modal).to have_valid_email |
There was a problem hiding this comment.
Are there any other things to check here? Maybe custom user fields?
pmusaraj
reviewed
May 17, 2024
pmusaraj
approved these changes
May 17, 2024
There was a problem hiding this comment.
@jancernik the new specs here are looking good. Please prioritize merging this before it gets too big.
Merging also helps stress test the specs, they'll run regularly and we will see if there are any flakeys.
jancernik
changed the title
ZogStriP
reviewed
May 17, 2024
ZogStriP
approved these changes
May 17, 2024
jancernik
force-pushed
the
auth-system-specs
branch
from
b9a0094
to
9d3aeb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.