Move API Keys to Admin from settings file. #1993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlite3.IntegrityError: NOT NULL constraint failed: djstripe_webhookendpoint.tolerance Fixes #1955
Instead djstripe_settings.WEBHOOK_TOLERANCE, since it was removed (#1967)
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs
Supercedes #1786
…them deterministic
…ue_account_api_key_default_per_key_type constraint
…ripe_apikey_secret_key constraint This constraint is created to handle violations of duplicate secret keys. This happens in case of adding an api key for non existent Platform accounts.
In case the key was added before the account was created, we end up creating the key before the Admin form gets created due to how the sync algorithm works. This commit will not correctly handle creation of APIKeys.
…ault In case the key was added before the account was created, we end up creating the key before the Admin form gets created due to how the sync algorithm works. This commit will not correctly handle creation of APIKeys.
…n settings if any
arnav13081994
force-pushed
the
feature/move_apis_to_admin
branch
from
5bce53a
to
5b8b9e5
Compare
arnav13081994
changed the title
|
@jleclanche This PR is ready for review. |
jleclanche
reviewed
Oct 3, 2023
djstripe/admin/forms.py
Outdated
| fields = ["name", "djstripe_is_account_default"] | ||
|
|
||
| @property | ||
| def construct_custom_error_message(self): |
There was a problem hiding this comment.
Make this a separate helper function that takes the type and the account as arguments, instead of a class member.
|
Could you include screenshots here of what the changes look like in the admin? |
|
@jleclanche Changes made. Description updated with screenshots of add and edit admin views. |
jleclanche
force-pushed
the
master
branch
2 times, most recently
from
bf4515d
to
d89e50e
Compare
|
Would like to have this merged so that I can switch everything to being managed through the database rather than having both settings and database. |
jleclanche
force-pushed
the
master
branch
3 times, most recently
from
15e04c3
to
8727894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
LIVE_API_KEYsettingTEST_API_KEYsettingSTRIPE_SECRET_KEYsettingSTRIPE_LIVE_SECRET_KEYsettingSTRIPE_TEST_SECRET_KEYsettingGET_DEFAULT_STRIPE_SECRET_KEYto get the default Secret API Key for the givenlivemodeanddjstripe_owner_accountstripe.api_keyin addition to adding API Keys to the db.djstripe_is_account_defaultso that it can be deduced in an unambguous way the defaultapi_keyfor a given keytype,livemode,djstripe_owner_accountwhendjstripe_is_account_defaultisTrue.Please note there are no migrations and tests as all that would be taken together. I have verified manually that all existing flows work as expected.