Feature/sites framework #337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a 'site' attribute to base model. Filter on current site for views Add admin filters for site attribute Update documentation to make sure the site framework is installed
…anager on Notification
madmoosey
approved these changes
Jun 22, 2022
|
@glibersat can you rebase your branch and maintain the same quotation marks pattern, please? |
|
@AlvaroLQueiroz Yes, I will, thank you for your feedback! |
|
Hi, I'm trying to fight my way back to project code style to remove black changes but it's kind of a hell, there are many different style mixed. Thank you! cc @yangyubo |
|
anyone can answer my previous question please? Thanks! |
|
Sorry for the late response @glibersat!! I'm focusing in V2. There these problems were solved and I don't pretend to fix this in version 1.x. The best option is to forget this PR, and open a new one for V2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
Following my issue #335 , here's a PR implementing it (
Sites Frameworkintegration to support multisites).Most of the work was to make it transparent for current users.
The only 'breaking' change is that you need to add manually the
sitesframework inINSTALLED_APPS(doc updated).For single site users, everything is defaulted to the current site and migrated to the first site created by the
sitesframework (ID=1).notifywill get the current site unless you explicitly pass it.Views will fetch only the current site notifications.
Admin will display and allow filtering by sites.
The old model manager is kept intact so the legacy custom code won't break and a new one,
on_site, was added to ease filtering.Let me know if that feels right and I'll be happy to change things if it helps merging it.
PS: There was a bit of black reformatting, I hope you don't mind!