New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the screenshots workflow. #18149
Conversation
👋🏻 @sarahboyce These were some things I thought could be improved that I spotted when I was reviewing #18080. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
5083a31
to
f8024b8
Compare
f8024b8
to
6e45237
Compare
6e45237
to
bfedfb2
Compare
[Note that I have done ever so slight changes to the commits but no changes to the content, I am approving the first 3 commits which are a series of improvements to the screenshots workflow. I will pull these out and merge separately. The last two commits each require manual test runs that I plan to do later.] |
bfedfb2
to
59cf325
Compare
The .execute_cdp_cmd() method doesn't exist on selenium.webdriver.Remote.
59cf325
to
e4bd0d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Trac ticket number
N/A
Branch description
Makes the following improvements to the screenshots workflow:
<case>/<test-name>-<name>.png
instead of<test-name>_<case>-<name>.png
<commit-hash>/<case>/<test-name>-<name>.png
These changes are particularly useful when generating a series of screenshots and downloading for comparison, making it easier to find things.
Checklist
main
branch.