Removed PY36 and PY37 version constants. #18154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
May 10, 2024
django/utils/version.py
Outdated
Comment on lines
16
to
19
| PY36 = sys.version_info >= (3, 6) | ||
| PY37 = sys.version_info >= (3, 7) | ||
| PY38 = sys.version_info >= (3, 8) | ||
| PY39 = sys.version_info >= (3, 9) |
There was a problem hiding this comment.
Please check the comment that it's written above these constants. Django 4.2 support Python 3.8 and 3.9 so we shouldn't remove PY38 and PY39.
As the oldest supported version is Django 4.2, we only need constants for PY38+. Thank you to Mariusz Felisiak for the review.
sarahboyce
force-pushed
the
remove-older-python
branch
from
276b109
to
3c9fa6f
Compare
sarahboyce
changed the title
felixxm
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could also remove PY310 as we are not using it but it could be used in future.