add naming rules to contributing #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sultaniman
reviewed
May 2, 2024
| * **exp** - an experiment where we are testing a new idea or want to demonstrate something to the team, might turn into a feat later (ticket encouraged) | ||
| * **test** - anything related to the tests (ticket encouraged) | ||
| * **blogs** - a new entry to our blog (ticket optional) | ||
| * **docs** - a change to our docs (ticket optional) |
There was a problem hiding this comment.
also maybe we can add infra for things related to CI
There was a problem hiding this comment.
should we also add refactor scope?
burnash
previously approved these changes
May 15, 2024
sultaniman
reviewed
May 21, 2024
CONTRIBUTING.md
Outdated
|
|
||
| #### Ticket Numbers | ||
|
|
||
| We encourage you to attach your branches to a ticket, if none exists, create one an explain what you are doing. For feat and fix branches, tickets are mandatory, for exp and test branches encouraged and for blogs and docs branches optional. |
There was a problem hiding this comment.
create one *an* -> and?
There was a problem hiding this comment.
and maybe enclose feat/fix in backticks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to add some rules how to name stuff (mostly branches). Let's discuss :)