Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rest_api verified source documentation #1308

Merged
merged 14 commits into from May 14, 2024
Merged

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented May 2, 2024

Implements #1268

Copy link

netlify bot commented May 2, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 913fa91
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66437cc554940a00087fa1c3
😎 Deploy Preview https://deploy-preview-1308--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash requested a review from rudolfix May 2, 2024 07:57
@sh-rp
Copy link
Collaborator

sh-rp commented May 2, 2024

Will there be some more docs on auth?

@burnash
Copy link
Collaborator Author

burnash commented May 3, 2024

TODO: Migrate more content from README

@burnash burnash self-assigned this May 8, 2024
@burnash burnash added the documentation Improvements or additions to documentation label May 8, 2024
Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few tiny comments

@burnash burnash force-pushed the enh/docs/add_rest_api branch 2 times, most recently from 972ddd7 to fdc5dfd Compare May 10, 2024 11:21
@rudolfix rudolfix added the sprint Marks group of tasks with core team focus at this moment label May 13, 2024
@rudolfix rudolfix merged commit c825759 into devel May 14, 2024
40 of 41 checks passed
@rudolfix rudolfix deleted the enh/docs/add_rest_api branch May 14, 2024 15:05
rudolfix added a commit that referenced this pull request May 14, 2024
* Add an example for post paginators

* update the example cursor key

* Update docs/website/docs/general-usage/http/rest-client.md

Co-authored-by: VioletM <sansiositres@gmail.com>

* Update docs/website/docs/general-usage/http/rest-client.md

Co-authored-by: VioletM <sansiositres@gmail.com>

* Update docs/website/docs/general-usage/http/rest-client.md

* Add rest_api verified source documentation (#1308)

* Add rest_api source docs

* Expand rest_api documentation

* Update snippets

* Update string aliases

* Link dlt source

* Reordered code in the example and added a new section

* Mention auto detection

* Reorder the sentence about paginator types and instances

* Elaborate on dependent resources; link the transformer docs

* Link incremental loading

* Update the example to use rest_api_resources

* Rename github_config

---------

Co-authored-by: Anton Burnashev <anton.burnashev@gmail.com>
Co-authored-by: VioletM <sansiositres@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation sprint Marks group of tasks with core team focus at this moment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants