Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlit caching and session state store fixes #1326

Merged
merged 4 commits into from May 13, 2024

Conversation

sultaniman
Copy link
Collaborator

This PR does the following things

  1. Lowers the TTL for query result cache to 1 minute (old was 5 minutes),
  2. Avoids storing schema in streamlit's session state store.

Issue: #1264

@sultaniman sultaniman added enhancement New feature or request community This issue came from slack community workspace labels May 6, 2024
@sultaniman sultaniman self-assigned this May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit e6f21cd
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/663dc3b22e5cb90008a257e5
😎 Deploy Preview https://deploy-preview-1326--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sultaniman sultaniman force-pushed the fix/issue-1264-streamlit-caching-improvements branch from e67d1b6 to 3363d75 Compare May 7, 2024 09:07
@sultaniman sultaniman marked this pull request as ready for review May 7, 2024 09:21
@sultaniman sultaniman changed the title Streamlit caching adjustments Streamlit caching and session state store fixes May 7, 2024
@sultaniman sultaniman requested a review from rudolfix May 7, 2024 09:21
@sultaniman sultaniman force-pushed the fix/issue-1264-streamlit-caching-improvements branch from 2956b9d to e6f21cd Compare May 10, 2024 06:50
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

and to be 100% honest I'd go back to single page application where we do not have any sessions state and use cache only for queries. way less side effects

@rudolfix rudolfix merged commit 4b09138 into devel May 13, 2024
48 of 50 checks passed
@rudolfix rudolfix deleted the fix/issue-1264-streamlit-caching-improvements branch May 13, 2024 22:04
@sultaniman
Copy link
Collaborator Author

@rudolfix yeah, I also agree with this, it rather better to have a single file instead of later trying to tackle the side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This issue came from slack community workspace enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants