-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] add script to generate meta info and upload to s3 #10295
Conversation
Some questions:
|
Hi @hcho3, It would be great if you can help on that. |
I've written a script to generate {
"platform_tag": "manylinux2014_x86_64",
"version": "2.1.0.dev0",
"commit_id": "6d65b593c65d130c1d67c6c5a1a1ba13c5b148f6"
} |
@trivialfis Can I get a review? I want your opinion on the new Python script ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could you please add a brief description of what the script format_wheel_meta.py
is doing and what it's for in its header, along with how I fetch the result? Maybe @wbo4958 can provide some more context here.
First, we can wget meta.json and parse it and get the platform/version/commit_id and then compose them with "https://s3-us-west-2.amazonaws.com/xgboost-nightly-builds/master/" to get the download link. |
Would it be useful to also include the full name of the wheel file in |
Hmm, yeah, good idea. |
The {
"wheel_name": "xgboost-2.1.0.dev0-py3-none-linux_x86_64.whl",
"platform_tag": "manylinux2014_x86_64",
"version": "2.1.0.dev0",
"commit_id": "6d65b593c65d130c1d67c6c5a1a1ba13c5b148f6"
} |
I would like to add a meta file to describe the latest xgboost nightly build info including xgboost version and commit id, and then upload it to s3, the file looks like that,
meta.xml
Hi @hcho3 Could you help review it.