-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support list of strings for Weaviate #1852
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 85.06% 82.71% -2.35%
==========================================
Files 136 136
Lines 9260 9270 +10
==========================================
- Hits 7877 7668 -209
- Misses 1383 1602 +219
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docarray/index/backends/weaviate.py
Outdated
int: 'number[]', | ||
float: 'number[]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a list of int in python should be mapped to 'int[]' in weaviate, since 'number[]' is for float64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for implementing this.
i just have 1 comment.
416a12d
to
af219af
Compare
📝 Docs are deployed on https://ft-weaviate-support-list-str--jina-docs.netlify.app 🎉 |
No description provided.