-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show field on pending document #1158
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
🚨 @ephraimduncan has 4 pull requests awaiting review. Please consider reviewing them when possible. 🚨 |
apps/web/src/app/(dashboard)/documents/[id]/document-page-view.tsx
Outdated
Show resolved
Hide resolved
@@ -162,13 +171,17 @@ export const DocumentPageView = async ({ params, team }: DocumentPageViewProps) | |||
</CardContent> | |||
</Card> | |||
|
|||
{document.status === DocumentStatus.PENDING && ( | |||
{document.status === DocumentStatus.COMPLETED && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to display fields for COMPLETED
documents since they're already imprinted onto the PDF itself
Description
This pull request introduces the functionality to display pending fields on the document page view. This enhancement allows users to see which fields are pending and need to be completed.
Changes Made
getPendingFieldsForDocument
function inpackages/lib/server-only/field/get-pending-fields-for-document.ts
to fetch pending fields for a document.DocumentPendingFields
indocument-pending-fields.tsx
to display the pending fields with options to hide individual fields.Testing Performed
Checklist
Additional Notes
No additional notes.