Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update AX_CXX_COMPILE_STDCXX to serial 18 #3494

Merged

Conversation

patricklodder
Copy link
Member

Downloaded the latest version available from https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html at the time of writing. This allows configuring for up to c++20.

Prerequisite for getting c++17 to work because the current version (4) only supports up to c++14.

@patricklodder patricklodder added this to the 1.15.0 milestone Mar 26, 2024
@patricklodder patricklodder requested a review from a team March 26, 2024 18:17
@patricklodder patricklodder added this to 🚀 needs review in Review & merge board Mar 26, 2024
@patricklodder

This comment was marked as resolved.

Downloaded the latest version available from
https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html
at the time of writing. This allows configuring for up to c++20.
@patricklodder
Copy link
Member Author

rebased to trigger a c++14 CI run

@patricklodder
Copy link
Member Author

Note: if we want to solve #3547, we'll need this to enable support for c++17 through autoconf.

@xanimo
Copy link
Member

xanimo commented May 27, 2024

utACK. no differences from src and dst

@chromatic
Copy link
Member

All tests pass and code looks good, but in my local checkout I see that the name Jörn is somehow misrendered. I see the same in the diff as shown on GitHub; is there a missing file encoding we need to add?

@patricklodder
Copy link
Member Author

[..] in my local checkout I see that the name Jörn is somehow misrendered. I see the same in the diff as shown on GitHub; is there a missing file encoding we need to add?

This appears to be an upstream issue, not ours, because the same character sequence is shown in GNU's repo

I propose to keep it the same as upstream - we get better traceability that way, and it's not up to us what the copyright line should say anyway.

@chromatic
Copy link
Member

Agreed on matching upstream.

Copy link
Member

@chromatic chromatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, all tests pass on x86-64 Linux. Text matches against upstream (with the caveat of potential encoding oddness, though that also reproduces against upstream Git).

@chromatic chromatic merged commit 9d6b484 into dogecoin:1.15.0-dev May 31, 2024
14 checks passed
@patricklodder patricklodder removed this from 🚀 needs review in Review & merge board May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants