-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update AX_CXX_COMPILE_STDCXX to serial 18 #3494
build: update AX_CXX_COMPILE_STDCXX to serial 18 #3494
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Downloaded the latest version available from https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html at the time of writing. This allows configuring for up to c++20.
414718f
to
6c3a24b
Compare
rebased to trigger a c++14 CI run |
Note: if we want to solve #3547, we'll need this to enable support for c++17 through autoconf. |
All tests pass and code looks good, but in my local checkout I see that the name |
This appears to be an upstream issue, not ours, because the same character sequence is shown in GNU's repo I propose to keep it the same as upstream - we get better traceability that way, and it's not up to us what the copyright line should say anyway. |
Agreed on matching upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, all tests pass on x86-64 Linux. Text matches against upstream (with the caveat of potential encoding oddness, though that also reproduces against upstream Git).
Downloaded the latest version available from https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html at the time of writing. This allows configuring for up to c++20.
Prerequisite for getting c++17 to work because the current version (4) only supports up to c++14.