[iOS] Not display InputAccessoryView closing the Software keyboard #22394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
mattleibow
reviewed
May 21, 2024
| #if !MACCATALYST | ||
| if(_keyboardObserverWillShow is not null) | ||
| { | ||
| NSNotificationCenter.DefaultCenter.RemoveObserver(_keyboardObserverWillShow); |
There was a problem hiding this comment.
I recall that Manuel was saying things that NSNotificationCenter is a bad API to use and creates leaks or something.
However, @tj-devel709 as our keyboard expert, is this the right place? Should we be putting things in some keyboard manager class or something that handles things? I know you have some special classes for keyboard things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Not display InputAccessoryView closing the Software keyboard on the Editor control.
NOTE: The d character is captured from the physical keyboard, closing the virtual one.
Issues Fixed
Fixes #22286