WIP feat(tiering): Defragmentation #3021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
May 7, 2024
src/server/tiered_storage.cc
Outdated
| void Defragment(tiering::DiskSegment segment, string_view value) { | ||
| auto hashes = ts_->bins_->DeleteBin(segment, value); | ||
| for (auto [dbid, hash] : hashes) { | ||
| auto it = db_slice_->GetDBTable(dbid)->prime.Find(hash); |
There was a problem hiding this comment.
who implemented find by hash value in dash table?
I can see this code in main branch..
There was a problem hiding this comment.
Nobody 🙂 It doesn't compile with what I pushed. Generally, we can't find a value just by hash, but we can loop over all values with the same hash and try finding a value that is external and lies on the given segment
There was a problem hiding this comment.
yes that is what yue did in a PR, you will also need to check that the external value offset is the same offset of the hash in the segment this way you can be sure its the same key
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.