[do not review] feat: add small wasmtime prototype #3038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
May 10, 2024
| @@ -1,3 +1,6 @@ | |||
| [submodule "helio"] | |||
| path = helio | |||
| url = https://github.com/romange/helio.git | |||
| [submodule "wasmtime"] | |||
| path = wasmtime | |||
There was a problem hiding this comment.
We should really use add_third_party. I couldn't make it work and I didn't want to loose time since this is just a prototype merely to show how we embed wasmtime, how we export API functions to sdk users, and how we consume wasm binaries in dragonfly
kostasrim
commented
May 10, 2024
| @@ -77,6 +77,11 @@ cxx_link(dragonfly_lib dfly_transaction dfly_facade redis_lib awsv2_lib jsonpath | |||
| http_client_lib absl::random_random TRDP::jsoncons ${ZSTD_LIB} TRDP::lz4 | |||
| TRDP::croncpp TRDP::flatbuffers) | |||
|
|
|||
| add_library(wasmtime STATIC IMPORTED) | |||
|
|
|||
| target_include_directories(dragonfly_lib PRIVATE ${CMAKE_SOURCE_DIR}/wasmtime/crates/c-api/include) | |||
kostasrim
commented
May 10, 2024
|
|
||
| std::string mod = "dragonfly"; | ||
| std::string export_f = "hello"; | ||
| wasm_valtype_vec_t arg_types; |
There was a problem hiding this comment.
We need proper APIs for all of these C functions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to use:
Before you call
cmakeorblazemake sure you compile wasmtime:Then call
blazeorcmake&&ninja dragonflyto compile.See
sdk/cpp/exampleon how to compile a UDF to wasm and executed in dragonfly viaCALLWASMcommand