allow Request class to be provided in options (#1563) #1593
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
drwpow
reviewed
Mar 18, 2024
| @@ -87,7 +89,7 @@ export default function createClient(clientOptions) { | |||
| request.params = params; // (re)attach params | |||
| const result = await m.onRequest(request, mergedOptions); | |||
| if (result) { | |||
| if (!(result instanceof Request)) { | |||
| if (!(result instanceof baseRequest)) { | |||
|
Yup this is looking great, and what I was thinking. This will need 2 things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR change? Link to any related issue(s).
Allows you to provide the Request class to use.
see: #1563
Caused issues for us using node 20's fetch, unidici's fetch, and node-fetch in different places.
Providing back as a base for someone else to continue, I may not have time soon.
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)