Fix: Errors in Create WorkSpace and Create API Key Processes #785
+43
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anirbanpaulcom is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
@steven-tey , @devkiran , Please take a look.Thank you! |
devkiran
requested changes
Apr 16, 2024
devkiran
requested changes
Apr 17, 2024
devkiran
reviewed
Apr 23, 2024
| errorResponse.error.message || | ||
| errorResponse || | ||
| "Something went wrong", | ||
| ); |
There was a problem hiding this comment.
I'm curious about when errorResponse is a string and when it's an object.
There was a problem hiding this comment.
What if we do this?
let errorResponse = await res.json();
if (errorResponse.error.message) {
toast.error(errorResponse.error.message);
} else {
errorResponse = await res.text();
toast.error(errorResponse || "Something went wrong");
}
}There was a problem hiding this comment.
@anirbanpaulcom In which case does the API return text vs JSON? Can you clarify?
There was a problem hiding this comment.
I was getting a text error response for Zod's error.
|
@anirbanpaulcom can you resolve the conflicts? |
@devkiran, Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing:
Screencast.from.16-04-24.12.09.16.PM.IST.webm
Screencast.from.16-04-24.01.11.46.PM.IST.webm