Validation added for 🗺️ #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@UsmanDev09 is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
@steven-tey is this okay or should i use the library to validate emoji regex? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #780
I have added validation for this emoji since our pattern
[\p{L}\p{N}\p{Pd}\/\p{Emoji}]+was failing to recognize it as emoji. However, there might be a lot of similar cases in future since new emojis are regularly added to unicode.Using this Library is a better solution since it generates the regex pattern at build time based on Unicode. Moreover, it can be updated whenever new emojis are added.