Expose threshold argument of Jaro-Winkler similarity #12079
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #10345, but starting with Jaro-Winkler similarity. This PR adds an optional third argument to the Jaro and Jaro-Winkler functions that acts as a "threshold" -- similarities below the threshold are reported as zero. This was already implemented in the vendored implementation of Jaro-Winkler, just not exposed to the DuckDB user.
If this is received positively, I'd like to update the vendored RapidFuzz and use it for all string comparisons, which would allow exposing this argument for those as well.
NOTE: I am not great at C++. I expect this will need a lot of cleanup.